Fix using a non-tuple sequence for multidimensional indexing that wil…#8732
Open
aarpon wants to merge 2 commits intoProject-MONAI:devfrom
Open
Fix using a non-tuple sequence for multidimensional indexing that wil…#8732aarpon wants to merge 2 commits intoProject-MONAI:devfrom
aarpon wants to merge 2 commits intoProject-MONAI:devfrom
Conversation
…l result in error in pytorch 2.9.
Contributor
📝 WalkthroughWalkthroughThis PR updates monai/inferers/utils.py to normalize tensor indexing across sliding-window inference by converting list-based indices to tuples. Changes apply to batched and non-batched paths when gathering window data and conditions, updating the sliding-window device buffer and final outputs, and when accumulating patch contributions in _compute_coords. No public API signatures are changed. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix using a non-tuple sequence for multidimensional indexing that will result in error in pytorch 2.9.
Fixes # .
Description
The
SlidingWindowInferercomplains that from PyTorch 2.9, using non-tuple sequences to slice into Tensors will result in an error (or, worse, misbehave). This patch targets all places inmonai/inferers/utils.pywhere indexing may happen with lists or other types of sequences.Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.